Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

From: Sean Paul
Date: Thu Sep 29 2016 - 13:29:51 EST

On Thu, Sep 29, 2016 at 8:04 AM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> Hi,
> On Tue, Sep 27, 2016 at 10:42:09AM -0400, Sean Paul wrote:
>> As an aside, it seems like (from the diff, I haven't looked at the
>> code) the bridge_pre_enable and bridge_post_disable calls are missing,
>> and the enable/disable calls are in the wrong place.
> Actually, I don't even think that's necessary. The atomic helpers
> already call drm_bridge_pre_enable and drm_bridge_enable at the right
> time. So I guess the proper fix would be to just remove the driver's
> call to drm_bridge_enable.

Yeah, that sounds good to me. I suppose this is one of the wonderful
ways that drm_bridge and drm_panel differ :-)


> Thanks!
> Maxime
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering