Re: [RESEND PATCH v2 1/4] mmc: core: switch to 1V8 or 1V2 for hs400es mode

From: Doug Anderson
Date: Thu Sep 29 2016 - 15:50:04 EST


Hi,

On Thu, Sep 22, 2016 at 5:12 PM, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote:
> When introducing hs400es, I didn't notice that we haven't
> switched voltage to 1V2 or 1V8 for it. That happens to work
> as the first controller claiming to support hs400es, arasan(5.1),
> which is designed to only support 1V8. So the voltage is fixed to 1V8.
> But it actually is wrong, and will not fit for other host controllers.
> Let's fix it.
>
> Fixes: commit 81ac2af65793ecf ("mmc: core: implement enhanced strobe support")
> Cc: <stable@xxxxxxxxxxxxxxx> 4.4#
> Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
>
> ---
>
> Changes in v2:
> - fix copy-paste error, mea culpa
>
> drivers/mmc/core/mmc.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)

This matches what's done for hs200 and also seems sane.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>