Re: [PATCH v14 4/4] CMDQ: save more energy in idle

From: Horng-Shyang Liao
Date: Fri Sep 30 2016 - 04:56:43 EST


On Fri, 2016-09-23 at 17:28 +0800, Horng-Shyang Liao wrote:
> On Thu, 2016-09-22 at 13:22 +0530, Jassi Brar wrote:
> > On Mon, Sep 5, 2016 at 7:14 AM, HS Liao <hs.liao@xxxxxxxxxxxx> wrote:
> > > Use clk_disable_unprepare instead of clk_disable to save more energy
> > > when CMDQ is idle.
> > >
> > > Signed-off-by: HS Liao <hs.liao@xxxxxxxxxxxx>
> > > ---
> > > drivers/mailbox/mtk-cmdq.c | 54 +++++++++++++++++++++++++++++++++++++++-------
> >
> > The driver is introduced by second patch of the set, so it makes sense
> > to merge this patch into patch 2/4.
>
> Hi Jassi,
>
> Could you take a look at previous discussion between Matthias and me?
> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05239.html
> His basic idea is to simplify first working version.
> Therefore, I move some code to this patch.
>
> Thanks,
> HS
>

Hi Jassi,

What do you think about our previous discussion?

Thanks,
HS