Re: [PATCH 2/2] net: hns: add missing function declaration
From: Arnd Bergmann
Date: Fri Sep 30 2016 - 10:33:48 EST
On Friday 30 September 2016, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:2784:5: warning: no previous prototype for 'hns_dsaf_roce_reset' [-Wmissing-prototypes]
> In fact, this function is not declared in any file, but should be
> declared in a header file. thus can be recognized in other file.
> so this patch adds the missing function declaration into
> Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>
If you get to a case like this, please describe in the changelog how you determined that
the function is there intentionally, rather than something that should be removed?
I also see that you had sent the patch series for hns previously, and had included
a 'v2' version in the subject, but left out the version this time. Please always
use increasing version numbers when you send a new version of the series.