Re: [PATCH 2/3] netfilter: hide reference to nf_hooks_ingress
From: Aaron Conole
Date: Fri Sep 30 2016 - 13:07:27 EST
Arnd Bergmann <arnd@xxxxxxxx> writes:
> A recent cleanup added an unconditional reference to the nf_hooks_ingress pointer,
> but that fails when CONFIG_NETFILTER_INGRESS is disabled and that member is
> not present in net_device:
> net/netfilter/core.c: In function 'nf_set_hooks_head':
> net/netfilter/core.c:96:30: error: 'struct net_device' has no member named 'nf_hooks_ingress'
> This avoids the build error by simply enclosing the assignment in an #ifdef,
> which may or may not be the correct fix.
NAK, it's not the right fix. The entry being set may be leaked with only this
hunk. I've posted a complete fix for this.
Sorry that it was broken.