Re: [PATCH][V2] dmaengine: coh901318: fix integer overflow when shifting more than 32 places

From: Vinod Koul
Date: Fri Sep 30 2016 - 13:40:53 EST


On Thu, Sep 29, 2016 at 07:14:38PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently U300_DMA_CHANNELS is set to 40, meaning that the shift of 1 can
> be more than 32 places, which leads to a 32 bit integer overflow. Fix this
> by using 1ULL instead of 1 before shifting it. Also add braces on the
> for-loop to keep with coding style conventions.

Applied, thanks

--
~Vinod