Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: use crc and cp version to determine roll-forward recovery

[Jaegeuk Kim]

On Sat, Oct 01, 2016 at 08:26:20AM +0800, Chao Yu wrote:
> On 2016/10/1 1:10, Jaegeuk Kim wrote:
> > @@ -1089,6 +1079,9 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc)
> >  	if (is_sbi_flag_set(sbi, SBI_NEED_FSCK))
> >  		set_ckpt_flags(ckpt, CP_FSCK_FLAG);
> >  
> > +	/* set this flag to activate crc|cp_ver for recovery */
> > +	set_ckpt_flags(ckpt, CP_CRC_RECOVERY_FLAG);
> 
> Should let new introduced spinlock cover the flag updating in ("f2fs: introduce
> cp_lock to protect updating of ckpt_flags").

Fixed.

http://git.kernel.org/cgit/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=aaec2b1d18792a5f27b69ff37f34f43f89f5aa3b

Thank you. :)

> 
> Thanks,