Re: [PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode

From: Andrew Lunn
Date: Mon Oct 03 2016 - 10:35:21 EST


> + Boolean:
> +
> + - enable-edpd : Not related to timing. Specify this property to enable
> + energy-detect power-down mode in the PHY.

The Broadcom PHYs unconditionally enable this feature.

The SMSC driver has an option: smsc,disable-energy-detect because it
seems to have a rare hardware bug when it is enabled.

And you would like to make it off by default.

Could we avoid having three drivers doing three different things?
Could you have it unconditionally on, and see if anybody reports it
being broken?

Andrew