Re: [PATCH] MIPS: ath79: Add initial support for the HAPROXY Aloha Pocket board

[Antony Pavlov]

On Tue, 4 Oct 2016 12:11:11 +0200
Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:

> On 10/04/2016 12:09 PM, Yegor Yefremov wrote:
> > Hi Neil,
> > 
> > On Tue, Oct 4, 2016 at 11:40 AM, Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
> >> On 10/04/2016 11:09 AM, Alban wrote:
> >>> On Mon,  3 Oct 2016 17:35:31 +0200
> >>> Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
> >>>
> >>>> The HAPROXY Aloha pocket board is a Load Balancer demo board based on the
> >>>> Atheros AR9331 SoC with 64Mbytes DDR and 16Mbytes on-board SPI Flash.
> >>>>
> >>>> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> >>>
> >>> Please use device tree instead of adding another board file.
> >>>
> >>> Alban
> >>>
> >>
> >> Hi Alban,
> >>
> >> I'm quite surprised since it seems no device tree support is available for ath79,
> >> I would really like to have device tree for this board, but this is only a copy/paste of
> >> the mach-ap121 with button/leds gpio differences.
> >>
> >> Could it be possible to merge it ? I would be happy to support this board once device tree
> >> support is landed on the mips tree !
> > 
> > Take a look at these DTS files from the current Linux tree:
> > 
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/mips/boot/dts/qca/ar9331_dpt_module.dts
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts
> > 
> > etc.
> > 
> > Regards,
> > Yegor
> > 
> 
> My bad, the qca naming is really disturbing.
> 
> I will push a dts instead.

Please note that currently some led's names in device tree files are wrong
(e.g. dragino2 device tree https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts .
My bad! I have just copied led's names from OpenWRT platform files).

Please see the 'LED Device Naming' chapter for correct led naming scheme:

  http://lxr.free-electrons.com/source/Documentation/leds/leds-class.txt#L41
 
-- 
Best regards,
  Antony Pavlov