Re: [PATCH V2] OMAPDSS: Kconfig: Add HDMI for OMAP4 and OMAP5 dependencies

From: Tomi Valkeinen
Date: Wed Oct 05 2016 - 02:06:29 EST


On 05/10/16 05:07, Adam Ford wrote:
> Make "HDMI for OMAP4" and "HDMI for OMAP5" depend on ARCH_OMAP4
> and SOC_OMAP5/DRA7XX respectively.
>
> Signed-off-by: Adam Ford <aford173@xxxxxxxxx>
>
> Changes in v2: Add dependancy for DRA7XX or OMAP5

You don't say it, but I presume this is just to make those kconfig
options disappear automatically if you don't have the specific ARCH_*
enabled?

I don't like these, as they will just clutter the Kconfig file. Here you
only added a few dependencies, but there are a lot more. VENC is only
there for some SoC versions, SDI is there only for some, same for
RFBI... And with every new SoC type we'd need to update all these.

Just disable the HDMI from the Kconfig if you don't want it included.

Tomi

Attachment: signature.asc
Description: OpenPGP digital signature