Re: [PATCH] Adding missing features of Coresight PTM components
From: Muhammad Abdul WAHAB
Date: Wed Oct 05 2016 - 06:33:23 EST
The rule of thumb when writing a patch description is to specify "why"
rather than "what" you are doing. The above describe the why alright
and should be kept. Everything below until your SOB describe what you
are doing and should be removed.
I modified the patch according to your remarks and will submit it.
> There is indeed an indentation problem here but it can't be fixed in
> this patch. Please do another patch for this.
I created another patch for it.
> The sysFS mode users can do what they want, including configurations
> not supported by the HW. There are so many rules and exception that
> adding a check for every one of they doesn't scale up. I suggest to
> remove the above check.
This check was removed. The return stack feature is not available in ETM
and the corresponding bit is reserved and should be zero. That's why an
additional check was made.
> You patch doesn't apply on my tree. Please use "git format-patch" for
> your next submission. Last but not least the email address in the
> "from:" part of the submission doesn't match the one in the SOB - they
> have to be similar.
All the above suggestions were made and will be submitted in the 2nd
version of the patch.