Re: [PATCH] staging: speakup: Replaced obsolete simple_strtoul

[Samuel Thibault]

Hello,

Jitendra Khasdev, on Thu 06 Oct 2016 02:02:58 +0530, wrote:
> From: Jitendra Kumar Khasdev <jkhasdev@xxxxxxxxx>
> 
> This patch is for replacing obsolete simple_strtoul to kstrtoul which remove warning produce by checkpatch.

> +	unsigned long val;
> +
> +	if (kstrtoul(start, 10, &val))
> +		return NULL;
>  
> -	val = simple_strtoul(skip_spaces(start), &start, 10);
>  	if (*start == ',')

simple_strtoul modifies start, so you can't just replace it with
kstrtoul.

Samuel