Re: [PATCH v6 RESEND] serial: rewrite pxa2xx-uart to use 8250_core

From: Greg Kroah-Hartman
Date: Thu Oct 06 2016 - 03:15:53 EST


On Thu, Oct 06, 2016 at 08:25:35AM +0200, Robert Jarzmik wrote:
> Robert Jarzmik <robert.jarzmik@xxxxxxx> writes:
>
> > From: Sergey Yanovich <ynvich@xxxxxxxxx>
> >
> > pxa2xx-uart was a separate uart platform driver. It was declaring
> > the same device names and numbers as 8250 driver. As a result,
> > it was impossible to use 8250 driver on PXA SoCs.
> >
> > Upon closer examination pxa2xx-uart turned out to be a clone of
> > 8250_core driver.
> >
> > Workaround for Erratum #19 according to Marvel(R) PXA270M Processor
> > Specification Update (April 19, 2010) is dropped. 8250_core reads
> > from FIFO immediately after checking DR bit in LSR.
> >
> > The patch leaves the original SERIAL_PXA driver around. The original
> > driver is just marked DEPRECATED in Kconfig and C source. When
> > the original driver is considered safe to remove, no changes
> > to SERIAL_8250 will be necessary.
> >
> > Compiling SERIAL_8250_CONSOLE and SERIAL_PXA_CONSOLE even without
> > SERIAL_8250_PXA breaks console for SERIAL_PXA. For this reasons, the new
> > and the original drivers are made mutually exclusive.
> >
> > Signed-off-by: Sergei Ianovich <ynvich@xxxxxxxxx>
> > CC: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > CC: James Cameron <quozl@xxxxxxxxxx>
> > CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > CC: Robert Jarzmik <robert.jarzmik@xxxxxxx>
> > CC: Russell King <linux@xxxxxxxxxxxxxxxx>
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > [rebased on v4.8]
> > Tested-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>
> > Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>
>
> Greg, can you take that into you tty tree please ?

Please wait until after the 4.9-rc1 merge window is over before worrying
about new patches being applied to my trees...

thanks,

greg k-h