[PATCH 4.7 086/141] mailbox: mailbox-test: set tdev->signal to NULL after freeing

From: Greg Kroah-Hartman
Date: Thu Oct 06 2016 - 05:38:21 EST

4.7-stable review patch. If anyone has any objections, please let me know.


From: Sudeep Holla <sudeep.holla@xxxxxxx>

commit 9ef3c5112139cc5c5666ee096e05bc1e00e94015 upstream.

tdev->signal is not set NULL after it's freed. This will cause random
exceptions when the stale pointer is accessed after tdev->signal is
freed. Also, since tdev->signal allocation is skipped the next time
it's written, this leads to continuous fault finally leading to the
total death of the system.

Fixes: d1c2f87c9a8f ("mailbox: mailbox-test: Prevent memory leak")
Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
Signed-off-by: Jassi Brar <jaswinder.singh@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

drivers/mailbox/mailbox-test.c | 1 +
1 file changed, 1 insertion(+)

--- a/drivers/mailbox/mailbox-test.c
+++ b/drivers/mailbox/mailbox-test.c
@@ -133,6 +133,7 @@ static ssize_t mbox_test_message_write(s
+ tdev->signal = NULL;

return ret < 0 ? ret : count;