[PATCH] serial: stm32: Fix comparisons with undefined register

From: Geert Uytterhoeven
Date: Thu Oct 06 2016 - 09:43:08 EST

drivers/tty/serial/stm32-usart.c: In function âstm32_receive_charsâ:
drivers/tty/serial/stm32-usart.c:130: warning: comparison is always true due to limited range of data type
drivers/tty/serial/stm32-usart.c: In function âstm32_tx_dma_completeâ:
drivers/tty/serial/stm32-usart.c:177: warning: comparison is always false due to limited range of data type

stm32_usart_offsets.icr is u8, while UNDEF_REG = ~0 is int, and thus

As all registers in stm32_usart_offsets are u8, change the definition of
UNDEF_REG to 0xff to fix this.

Fixes: ada8618ff3bfe183 ("serial: stm32: adding support for stm32f7")
Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Untested due to lack of hardware.
drivers/tty/serial/stm32-usart.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/stm32-usart.h b/drivers/tty/serial/stm32-usart.h
index 41d97492310271db..cd97ceb76e4ffe6f 100644
--- a/drivers/tty/serial/stm32-usart.h
+++ b/drivers/tty/serial/stm32-usart.h
@@ -31,7 +31,7 @@ struct stm32_usart_info {
struct stm32_usart_config cfg;

-#define UNDEF_REG ~0
+#define UNDEF_REG 0xff

/* Register offsets */
struct stm32_usart_info stm32f4_info = {