Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA

[Geert Uytterhoeven]

On Thu, Oct 6, 2016 at 4:06 PM, Timur Tabi <timur@xxxxxxxxxxxxxx> wrote:
> Geert Uytterhoeven wrote:
>>
>>   config QCOM_EMAC
>>         tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet
>> support"
>> +       depends on HAS_DMA
>
>
> I think it needs to depend on HAS_IOMEM as well, to fix this error in
> arch/um:
>
>    drivers/net/ethernet/qualcomm/emac/emac.c: In function 'emac_remove':
>>> drivers/net/ethernet/qualcomm/emac/emac.c:727:3: error: implicit
>>> declaration of function 'iounmap' [-Werror=implicit-function-declaration]
>       iounmap(adpt->phy.digital);

Probably, I don't do UML allmodconfig builds.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds