Re: [PATCH] clk: max77686: fix number of clocks setup for clk_hw based registration

From: Krzysztof Kozlowski
Date: Thu Oct 06 2016 - 13:23:03 EST


On Thu, Oct 06, 2016 at 11:59:59AM -0300, Javier Martinez Canillas wrote:
> The commit 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and
> registration APIs") converted the driver to use the new provider API to
> register clocks using clk_hw.
>
> But unfortunately, in the conversion it missed to set the num_clks value
> which lead to the following error when trying to register a clk provider:
>
> [ 1.963782] of_clk_max77686_get: invalid index 0
> [ 1.967460] ERROR: could not get clock /rtc@10070000:rtc_src(1)
> [ 1.973638] s3c-rtc 10070000.rtc: failed to find rtc source clock
>
> Fix it by correctly set the max77686_clk_driver_data num_clks member.
>
> Fixes: 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and registration APIs")
> Reported-by: Markus Reichl <m.reichl@xxxxxxxxxxxxx>
> Suggested-by: Tobias Jakobi <tjakobi@xxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> Tested-by: Markus Reichl <m.reichl@xxxxxxxxxxxxx>
>
> ---
>
> drivers/clk/clk-max77686.c | 1 +
> 1 file changed, 1 insertion(+)

Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Best regards,
Krzysztof