Re: [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM

From: David Miller
Date: Thu Oct 06 2016 - 21:14:15 EST


From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Date: Thu, 6 Oct 2016 16:44:53 +0200

> If NO_DMA=y:
>
> drivers/built-in.o: In function `emac_probe':
> emac.c:(.text+0x3780b8): undefined reference to `bad_dma_ops'
> emac.c:(.text+0x3780e2): undefined reference to `bad_dma_ops'
> emac.c:(.text+0x378112): undefined reference to `bad_dma_ops'
> emac.c:(.text+0x378146): undefined reference to `bad_dma_ops'
> emac.c:(.text+0x37816e): undefined reference to `bad_dma_ops'
> drivers/built-in.o:emac.c:(.text+0x37819a): more undefined references to `bad_dma_ops' follow
>
> If NO_IOMEM=y:
>
> drivers/net/ethernet/qualcomm/emac/emac.c: In function ʽemac_removeʼ:
> drivers/net/ethernet/qualcomm/emac/emac.c:736:3: error: implicit declaration of function ʽiounmapʼ [-Werror=implicit-function-declaration]
> iounmap(adpt->phy.digital);
> ^
>
> Add dependencies on HAS_DMA and HAS_IOMEM to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Applied.