Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

From: Viresh Kumar
Date: Thu Oct 06 2016 - 23:34:07 EST


On 06-10-16, 07:51, Markus Mayer wrote:
> During early development, when the driver couldn't fully register, I
> would see the init() function called four times, i.e. once for each
> core. If the first call succeeded, that was it. It would only get
> called once. But if it failed, all cores would try to register. And I
> wanted to avoid spilling the same error message four times.

This is the current behavior of the cpufreq core.

> I'll look at that again. It may have had something to do with how the
> driver worked back then. If it doesn't happen anymore, I'll just get
> rid of this code.

I don't think so, but again, we don't need to have special code to save few
lines which get printed only in the rare case of errors.

--
viresh