RE: [PATCH v7 2/6] mfd: lpc_ich: Rename lpc-ich driver

[Tan, Jui Nee]

> -----Original Message-----
> From: Lee Jones [mailto:lee.jones@xxxxxxxxxx]
> Sent: Friday, September 30, 2016 8:31 AM
> To: Tan, Jui Nee <jui.nee.tan@xxxxxxxxx>
> Cc: mika.westerberg@xxxxxxxxxxxxxxx; heikki.krogerus@xxxxxxxxxxxxxxx;
> andriy.shevchenko@xxxxxxxxxxxxxxx; tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx;
> hpa@xxxxxxxxx; x86@xxxxxxxxxx; ptyser@xxxxxxxxxxx;
> linus.walleij@xxxxxxxxxx; linux-gpio@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Yong, Jonathan <jonathan.yong@xxxxxxxxx>; Yu, Ong
> Hock <ong.hock.yu@xxxxxxxxx>; Luck, Tony <tony.luck@xxxxxxxxx>; Wan
> Mohamad, Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@xxxxxxxxx>
> Subject: Re: [PATCH v7 2/6] mfd: lpc_ich: Rename lpc-ich driver
> 
> On Wed, 28 Sep 2016, Tan Jui Nee wrote:
> 
> > This patch follows the example of mfd/wm831x to rename the driver from
> > "lpc_ich" to "lpc_ich-core".
> >
> > Signed-off-by: Tan Jui Nee <jui.nee.tan@xxxxxxxxx>
> > ---
> > Changes in V7:
> > 	- No change
> >
> > Changes in V6:
> > 	- none, just a subject line and commit message change.
> >
> >  drivers/mfd/Makefile                      | 1 +
> >  drivers/mfd/{lpc_ich.c => lpc_ich-core.c} | 0
> >  2 files changed, 1 insertion(+)
> >  rename drivers/mfd/{lpc_ich.c => lpc_ich-core.c} (100%)
> >
> > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index
> > 2ba3ba3..260f46f 100644
> > --- a/drivers/mfd/Makefile
> > +++ b/drivers/mfd/Makefile
> > @@ -155,6 +155,7 @@ obj-$(CONFIG_PMIC_ADP5520)	+= adp5520.o
> >  obj-$(CONFIG_MFD_KEMPLD)	+= kempld-core.o
> >  obj-$(CONFIG_MFD_INTEL_QUARK_I2C_GPIO)	+= intel_quark_i2c_gpio.o
> >  obj-$(CONFIG_LPC_SCH)		+= lpc_sch.o
> > +lpc_ich-objs		:= lpc_ich-core.o
> 
> Please use underscores OR obliques, not both.
> 
Noted. I will send out another patch-set with filename lpc_ich_core.
> >  obj-$(CONFIG_LPC_ICH)		+= lpc_ich.o
> >  obj-$(CONFIG_MFD_RDC321X)	+= rdc321x-southbridge.o
> >  obj-$(CONFIG_MFD_JANZ_CMODIO)	+= janz-cmodio.o
> > diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich-core.c
> > similarity index 100% rename from drivers/mfd/lpc_ich.c rename to
> > drivers/mfd/lpc_ich-core.c
> 
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead Linaro.org â Open source
> software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog