Re: [PATCH] ftrace: Support full glob matching

From: Masami Hiramatsu
Date: Fri Oct 07 2016 - 05:04:31 EST


On Wed, 5 Oct 2016 09:36:35 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Wed, 5 Oct 2016 20:58:15 +0900
> Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
>
> > Use glob_match() to support flexible glob wildcards (*,?)
> > and character classes ([) for ftrace.
> > Since the full glob matching is slower than the current
> > partial matching routines(*pat, pat*, *pat*), this leaves
> > those routines and just add MATCH_GLOB for complex glob
> > expression.
> >
> > e.g.
> > ----
> > [root@localhost tracing]# echo 'sched*group' > set_ftrace_filter
> > [root@localhost tracing]# cat set_ftrace_filter
> > sched_free_group
> > sched_change_group
> > sched_create_group
> > sched_online_group
> > sched_destroy_group
> > sched_offline_group
> > [root@localhost tracing]# echo '[Ss]y[Ss]_*' > set_ftrace_filter
> > [root@localhost tracing]# head set_ftrace_filter
> > sys_arch_prctl
> > sys_rt_sigreturn
> > sys_ioperm
> > SyS_iopl
> > sys_modify_ldt
> > SyS_mmap
> > SyS_set_thread_area
> > SyS_get_thread_area
> > SyS_set_tid_address
> > sys_fork
> > ----
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
>
> Nice! Although, I probably wont get to look at this till I get back
> from Berlin. Please send me a friendly "ping" on the 17th.

OK, I'm also considering update ftracetest too for recent features.
Maybe I would better make a series including this.

> I'll still add it to my new "todo" folder. Since, just marking patches
> in my inbox as todo hasn't been working out for me, I've created a
> separate folder for ftrace patches.

:)

Thanks!

>
> Thanks!
>
> -- Steve


--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>