Re: [tip:x86/apic] x86/acpi: Introduce persistent storage for cpuid <-> apicid mapping

[Thomas Gleixner]

On Thu, 6 Oct 2016, Yinghai Lu wrote:
> On Thu, Oct 6, 2016 at 1:06 AM, Dou Liyang <douly.fnst@xxxxxxxxxxxxxx> wrote:
> Yes, that should work. but should do the same thing for x2apic
> 
> in acpi_parse_x2apic should have
> 
> > +       if (processor->local_apic_id == -1) {
> > +               ++disabled_cpus;
> > +               return -EINVAL;
> > +       }
> 
> that is the reason why i want to extend acpi_register_lapic()
> to take extra disabled_id (one is 0xff and another is 0xffffffff)
> so could save some lines.

That just makes the code harder to follow and is not really worth the
trouble.

Thanks,

	tglx