Re: [PATCH] net: Reset skb to network header in neigh_hh_output

[Sergei Shtylyov]

Hello.

On 10/07/2016 05:14 PM, Abdelrhman Ahmed wrote:

> When hardware header is added without using cached one, neigh_resolve_output
> and neigh_connected_output reset skb to network header before adding it.
> When cached one is used, neigh_hh_output does not reset the skb to network
> header.
>
> The fix is to reset skb to network header before adding cached hardware header
> to keep the behavior consistent in all cases.
>
> Signed-off-by: Abdelrhman Ahmed <ab@xxxxxxxxxxx>
> ---
>  include/net/neighbour.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/net/neighbour.h b/include/net/neighbour.h
> index 8b68384..4d89fc2 100644
> --- a/include/net/neighbour.h
> +++ b/include/net/neighbour.h
> @@ -424,7 +424,7 @@ static inline struct neighbour * neigh_clone(struct neighbour *neigh)
>  static inline int neigh_event_send(struct neighbour *neigh, struct sk_buff *skb)
>  {
>         unsigned long now = jiffies;
> -
> +

   Unraleted white-space change.

>         if (neigh->used != now)
>                 neigh->used = now;
>         if (!(neigh->nud_state&(NUD_CONNECTED|NUD_DELAY|NUD_PROBE)))
[...]

MBR, Sergei