Re: [PATCH v2 2/4] ACPI / gpio: Add support for naming GPIOs
From: Andy Shevchenko
Date: Fri Oct 07 2016 - 13:05:30 EST
On Thu, Sep 29, 2016 at 4:39 PM, Mika Westerberg
> DT has property 'gpio-line-names' to name GPIO lines the controller has if
> present. Use this very same property in ACPI as well to provide nice names
> for the GPIOS.
One nit below.
> @@ -835,6 +875,9 @@ void acpi_gpiochip_add(struct gpio_chip *chip)
> + if (!chip->names)
> + acpi_gpiochip_set_names(acpi_gpio);
I'm okay with this, though wouldn't be better to call it
unconditionally like it's done for below call and move check inside?
With Best Regards,