Re: [PATCH v2 2/4] ACPI / gpio: Add support for naming GPIOs

[Andy Shevchenko]

On Thu, Sep 29, 2016 at 4:39 PM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> DT has property 'gpio-line-names' to name GPIO lines the controller has if
> present. Use this very same property in ACPI as well to provide nice names
> for the GPIOS.

One nit below.

> @@ -835,6 +875,9 @@ void acpi_gpiochip_add(struct gpio_chip *chip)
>                 return;
>         }
>
> +       if (!chip->names)
> +               acpi_gpiochip_set_names(acpi_gpio);
> +

I'm okay with this, though wouldn't be better to call it
unconditionally like it's done for below call and move check inside?

>         acpi_gpiochip_request_regions(acpi_gpio);
>         acpi_walk_dep_device_list(handle);
>  }

-- 
With Best Regards,
Andy Shevchenko