Re: BUG_ON() in workingset_node_shadows_dec() triggers

From: Kees Cook
Date: Fri Oct 07 2016 - 13:33:49 EST

On Fri, Oct 7, 2016 at 10:21 AM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Oct 7, 2016 at 10:16 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>> Regardless, I still think that we can't let BUG continue kernel
>> execution though, since it may lead to entirely unexpected behavior
>> (possibly security-sensitive) by still running. Upgrading BUG to
>> panic(), though, I'd be fine with, as a way to get people to convert
>> to WARN.
> No. Really. You can upgrade BUG() to "panic()" with a kernel command
> line. But not by default.
> I'm not going to take any patches that make BUG() even *worse*. That
> would be insane. I'm not insane.

I'll quit debating how to change things, but I'll just try to point
out that the "stop execution" logic, currently, is not an accident.
Without CONFIG_BUG, BUG is defined as "do {} while (1)", and without
CONFIG_HAVE_ARCH_BUG, BUG is defined as "printk(...); panic(...);".


Kees Cook
Nexus Security