Re: [PATCH] pinctrl: intel: Configure GPIO chip IRQ as wakeup interrupts

From: Andy Shevchenko
Date: Fri Oct 07 2016 - 13:59:53 EST

On Thu, Sep 22, 2016 at 2:03 AM, Nilesh Bacchewar
<nilesh.bacchewar@xxxxxxxxx> wrote:
> On some Intel BXT platform, wake-up from suspend-to-idle on pressing
> power-button is not working. Its noticed that gpio-keys driver marking the
> second level IRQ/power-button as wake capable but Intel pintctrl
> driver is missing to mark GPIO chip/controller IRQ which first level IRQ
> as wake cable if its GPIO pin IRQ is wakeble. So, though the first level
> IRQ gets generated on power-button press, since it is not marked as
> wake capable resume/wake-up flow is not happening.
> Intel pintctrl/GPIO driver need to mark GPIO chip/controller IRQ (first
> level IRQ) as wake capable iff GPIO pin's IRQ (second level IRQ) is marked
> as wake cable.

> if (on)
> - gpe_en |= BIT(gpp_offset);
> + enable_irq_wake(pctrl->irq);
> else
> - gpe_en &= ~BIT(gpp_offset);
> - writel(gpe_en, community->regs + GPI_GPE_EN + gpp * 4);
> -
> - raw_spin_unlock_irqrestore(&pctrl->lock, flags);
> + disable_irq_wake(pctrl->irq);

Shouldn't be refcounting here or I missed something?
What I think of is 2+ GPIO lines marked as wake capable IRQ sources
and one of them is disabled earlier by some reason.

With Best Regards,
Andy Shevchenko