RE: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb

[Winkler, Tomas]

> -----Original Message-----
> From: Jarkko Sakkinen [mailto:jarkko.sakkinen@xxxxxxxxxxxxxxx]
> Sent: Saturday, October 08, 2016 19:01
> To: Winkler, Tomas <tomas.winkler@xxxxxxxxx>
> Cc: tpmdd-devel@xxxxxxxxxxxxxxxxxxxxx; Jason Gunthorpe
> <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb
> 
> On Sat, Oct 08, 2016 at 01:37:31PM +0000, Winkler, Tomas wrote:
> > >
> > > On Sat, Oct 08, 2016 at 02:59:39PM +0300, Tomas Winkler wrote:
> > > > From: "Winkler, Tomas" <tomas.winkler@xxxxxxxxx>
> > > >
> > > > Utilize runtime_pm for driving tpm crb idle states.
> > > > The framework calls cmd_ready from the pm_runtime_resume handler
> > > > and go idle from the pm_runtime_suspend handler.
> > > > The TPM framework should wake the device before transmit and receive.
> > > > In case the runtime_pm framework is not compiled in or enabled,
> > > > the device will be in the permanent ready state.
> > > >
> > > > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> > >
> > > I would rather want the fix as a separate patch to make review +
> > > testing easier (without and with). Thanks.
> >
> > But you've dropped the patches, so I've resent them.
> > Can you do the diff yourself, just branch it off.  it's really just
> > few lines
> 
> Nope. I have only dropped the workaround.

This is what is current in the linus tree:

git log --oneline linux/master -- drivers/char/tpm/

324152502b0e Revert "tpm/tpm_crb: implement tpm crb idle state"
cfa188220363 Revert "tmp/tpm_crb: fix Intel PTT hw bug during idle state"
2b7926ae1cd4 Revert "tpm/tpm_crb: open code the crb_init into acpi_add"
4886cd80cb8e Revert "tmp/tpm_crb: implement runtime pm for tpm_crb"
e350e24694e4 tmp/tpm_crb: implement runtime pm for tpm_crb
0c22db435bf7 tpm/tpm_crb: open code the crb_init into acpi_add
9514ff1961c6 tmp/tpm_crb: fix Intel PTT hw bug during idle state
e17acbbb69d3 tpm/tpm_crb: implement tpm crb idle state