Re: pci_alloc_irq_vectors use in 8250_lpss.c

From: Andy Shevchenko
Date: Sun Oct 09 2016 - 18:08:29 EST

On Sun, Oct 9, 2016 at 8:56 PM, Christoph Hellwig <hch@xxxxxx> wrote:
> Hi Andy,
> two comment on your ãatch to add MSI support to the above driver.
> First pci_alloc_irq_vectors gained a mandatory flags argument, so
> for MSI suport you now need to pass PCI_IRQ_MSI in flags for the
> code to work.

I will check this. Thanks for pointing to it.

> Second please make sure to always pair pci_alloc_irq_vectors
> with pci_free_irq_vectors on the remove path.

For my opinion it should be done in PCI code since I'm using
manageable resources. It's already done for all PCI API usually used
at ->probe().

With Best Regards,
Andy Shevchenko