Re: [PATCH 1/1] gpu: drm: gma500: Use vma_pages()

From: Shyam Saini
Date: Sun Oct 09 2016 - 21:53:17 EST


On Mon, 2016-10-10 at 01:46 +0200, Patrik Jakobsson wrote:
> On Mon, Oct 10, 2016 at 1:07 AM, Shyam Saini <mayhs11saini@xxxxxxxxx>
> wrote:
> >
> > Replace explicit computation of vma page count by a call to
> > vma_pages()
> Hi, I already have this patch in the "queue" from:
> Muhammad Falak R Wani <falakreyaz@xxxxxxxxx>
>
> Will include that one when I get around to sending out a PR.
>
> Thanks
> Patrik
>
> >
> >
> > Signed-off-by: Shyam Saini <mayhs11saini@xxxxxxxxx>
> > ---
> > Âdrivers/gpu/drm/gma500/framebuffer.c | 2 +-
> > Â1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/gma500/framebuffer.c
> > b/drivers/gpu/drm/gma500/framebuffer.c
> > index 3a44e70..0fde850 100644
> > --- a/drivers/gpu/drm/gma500/framebuffer.c
> > +++ b/drivers/gpu/drm/gma500/framebuffer.c
> > @@ -124,7 +124,7 @@ static int psbfb_vm_fault(struct vm_area_struct
> > *vma, struct vm_fault *vmf)
> > ÂÂÂÂÂÂÂÂunsigned long phys_addr = (unsigned long)dev_priv-
> > >stolen_base +
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂpsbfb->gtt->offset;
> >
> > -ÂÂÂÂÂÂÂpage_num = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> > +ÂÂÂÂÂÂÂpage_num = vma_pages(vma);
> > ÂÂÂÂÂÂÂÂaddress = (unsigned long)vmf->virtual_address - (vmf->pgoff
> > << PAGE_SHIFT);
> >
> > ÂÂÂÂÂÂÂÂvma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
> > --
> > 2.7.4
> >

No issue.

Thanks