RE: [PATCH] xenbus: advertize control feature flags

[Paul Durrant]

> -----Original Message-----
> From: Juergen Gross [mailto:jgross@xxxxxxxx]
> Sent: 10 October 2016 10:11
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>; David Vrabel
> <david.vrabel@xxxxxxxxxx>
> Subject: Re: [PATCH] xenbus: advertize control feature flags
> 
> On 10/10/16 09:43, Paul Durrant wrote:
> > The Xen docs specify several flags which a guest can set to advertize
> > which values of the xenstore control/shutdown key it will recognize.
> > This patch adds code to write all the relevant feature-flag keys.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> > Cc: David Vrabel <david.vrabel@xxxxxxxxxx>
> > Cc: Juergen Gross <jgross@xxxxxxxx>
> > ---
> >  drivers/xen/manage.c | 45 +++++++++++++++++++++++++++++++++++--
> --------
> >  1 file changed, 35 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
> > index e12bd36..86cf57c 100644
> > --- a/drivers/xen/manage.c
> > +++ b/drivers/xen/manage.c
> > @@ -170,6 +170,7 @@ out:
> >  struct shutdown_handler {
> >  	const char *command;
> >  	void (*cb)(void);
> > +	bool flag;
> >  };
> >
> >  static int poweroff_nb(struct notifier_block *cb, unsigned long code, void
> *unused)
> > @@ -206,21 +207,22 @@ static void do_reboot(void)
> >  	ctrl_alt_del();
> >  }
> >
> > +static struct shutdown_handler shutdown_handlers[] = {
> > +	{ "poweroff", do_poweroff, true },
> > +	{ "halt", do_poweroff, true },
> > +	{ "reboot", do_reboot, false },
> 
> I think you meant to set the flag to "false" for halt and "true" for
> reboot, no?
> 

Yes, you're right. Don't know why I got that backwards. Will fix in v2.

  Paul

> 
> Juergen