Re: [PATCH] perf annotate: Cleanup arch specific stuff

[Naveen N. Rao]

On 2016/10/10 01:24PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Oct 10, 2016 at 07:29:02PM +0530, Ravi Bangoria escreveu:
> > Move arch specific stuff from util/annotate.c to their respective
> > files in util/annotate directory.
> > 
> > No functionality changes.
> > 
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxxxxxxx>
> > ---
> >  tools/perf/util/Build              |   1 +
> >  tools/perf/util/annotate.c         | 259 +++----------------------------------
> >  tools/perf/util/annotate.h         |  23 ++++
> >  tools/perf/util/annotate/Build     |   3 +
> >  tools/perf/util/annotate/arm.c     |  50 +++++++
> >  tools/perf/util/annotate/powerpc.c |  63 +++++++++
> >  tools/perf/util/annotate/x86.c     | 107 +++++++++++++++
> 
> We already have a per arch area: tools/perf/arch/

I think this was done to support cross-arch annotate similar to the 
remote unwind support with util/libunwind/

- Naveen