Re: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas

From: atull
Date: Mon Oct 10 2016 - 14:38:27 EST

On Fri, 7 Oct 2016, Moritz Fischer wrote:

> Hi Alan,
> On Fri, Oct 7, 2016 at 11:21 AM, atull <atull@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > Moritz, Can you remind me what that issue was there (or point me to
> > that email, I can't find it)? I don't think I had a problem with that
> > in your case. In general I think if these drivers can take the
> > bitstream that comes from the manufacturer's tools and stuff it into
> > the FPGA, then we are accomplishing what we want. So I am OK with
> > this here. The intent of the driver is to load a standard rbf, same
> > as the other Altera FPGA drivers.
> My first version of the zynq fpga manager had byte swapping in there
> and detection of which format was used. Greg even (accidentially)
> merged my initial code
> which I then cleaned up in 4d10eaff5bfc69997a769f9c83b749f0a8c542fa
> ("fpga: zynq-fpga: Change fw format to handle bin instead of bit.") to
> address the review
> comments.
> I do see your point about useability, and if this is something that
> keeps coming up
> we could pull that into the framework with a flag to SWAP or as part
> of the image_information
> struct.
> Thoughts?

I agree. Some day we may want to see it useful to extend
the flow to do that. Currently it's not needed so we can
wait until we see clearly what is needed.


> Cheers,
> Moritz
> [1]