Re: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate".
From: Andrzej Hajda
Date: Tue Oct 11 2016 - 05:18:40 EST
This patch misses dsi bus un-registration.
However I have reviewed two patches of Takashi which solves
the same issue more completely . These patches were not
On 11.10.2016 10:40, Sun, Jing A wrote:
> Dear Maintainers,
> It's needed that DRM Driver module could be removed and reloaded after kernel booting on the projects that I have been working on, and I hope such module type change could be accepted. Looks like Iwai has similar change request as well. Would you please review it and let us know if any concerns?
> Sun, Jing
> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@xxxxxxx]
> Sent: Monday, October 10, 2016 5:57 PM
> To: Jani Nikula
> Cc: Sun, Jing A; airlied@xxxxxxxx; Vetter, Daniel; linux-kernel@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; Takashi Iwai; a.hajda@xxxxxxxxxxx; Thierry Reding
> Subject: Re: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate".
> On Mon, 10 Oct 2016 10:28:31 +0200,
> Jani Nikula wrote:
>> On Mon, 10 Oct 2016, "Sun, Jing A" <jing.a.sun@xxxxxxxxx> wrote:
>>> Dear Maintainers,
>>> Please kindly review my patch as below. It's based on the mainline branch.
>>> From b401009f79883ac5e9d41525c9d54b800ece2e22 Mon Sep 17 00:00:00
>>> From: Jing SUN <jing.a.sun@xxxxxxxxx>
>>> Date: Mon, 10 Oct 2016 14:06:54 +0800
>>> Subject: [PATCH 1/1] drm: change DRM_MIPI_DSI module type from
>>> "bool" to "tristate".
>>> A lot of drm driver modules, which are designed to be loadable,
>>> select DRM_MIPI_DSI, while that being "bool" prevents those from
>>> getting reloaded.
>> You're missing some lists and people from distribution, added now.
>> See the discussion starting at . I don't know if anything has
>> happened since then. Takashi?
> Unfortunately, nothing seems to have happened since my last patch due to little interest. I'd be glad if the patch is revived.
> (BTW, I'm traveling in these two weeks, so the further reply will be
>>  http://lkml.kernel.org/r/s5hh9bhvj7j.wl-tiwai@xxxxxxx
>>> Signed-off-by: Jing SUN <jing.a.sun@xxxxxxxxx>
>>> drivers/gpu/drm/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index
>>> fc35731..67668a0 100644
>>> --- a/drivers/gpu/drm/Kconfig
>>> +++ b/drivers/gpu/drm/Kconfig
>>> @@ -22,7 +22,7 @@ menuconfig DRM
>>> (/dev/agpgart) support if it is available for your platform.
>>> config DRM_MIPI_DSI
>>> - bool
>>> + tristate
>>> depends on DRM
>>> config DRM_DP_AUX_CHARDEV
>> Jani Nikula, Intel Open Source Technology Center