Re: [PATCH v3] xenbus: advertize control feature flags

From: David Vrabel
Date: Tue Oct 11 2016 - 07:29:08 EST

On 11/10/16 11:53, Juergen Gross wrote:
> On 10/10/16 12:13, Paul Durrant wrote:
>> The Xen docs specify several flags which a guest can set to advertize
>> which values of the xenstore control/shutdown key it will recognize.
>> This patch adds code to write all the relevant feature-flag keys.
>> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
>> Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>> Cc: David Vrabel <david.vrabel@xxxxxxxxxx>
>> Cc: Juergen Gross <jgross@xxxxxxxx>
> Hmm, I'd prefer node[] allocated on the stack over dynamic allocation.
> What about something like the following? It will at least issue build
> warnings in case the size is too small, will use less memory and less
> coding.

You still want snprintf() just to be sure. You can add a Reviewed-by
David Vrabel <david.vrabel@xxxxxxxxxx> if you make this change.