Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change

From: Andrew Lunn
Date: Tue Oct 11 2016 - 16:57:35 EST

Next message: Ondrej Zary: "Re: [PATCH] scsi: NCR5380: no longer mark irq probing as __init"
Previous message: kernel test robot: "[mm] c4344e8035: WARNING: CPU: 0 PID: 101 at mm/memory.c:303 __tlb_remove_page_size+0x25/0x99"
In reply to: Florian Fainelli: "Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change"
Next in thread: Zach Brown: "Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> Andrew, are you happy with this implementation?

Sorry, been to busy with other things to follow the discussion.

What would be nice to see is a comment about how the link to LEDs in
the PHYs is made. Often there is a couple of LEDs in the RJ45 socket
driven by the PHY. They can show link, speed, packet Rx/Tx, etc. How
are these triggers related to these LEDs?

Andrew

Next message: Ondrej Zary: "Re: [PATCH] scsi: NCR5380: no longer mark irq probing as __init"
Previous message: kernel test robot: "[mm] c4344e8035: WARNING: CPU: 0 PID: 101 at mm/memory.c:303 __tlb_remove_page_size+0x25/0x99"
In reply to: Florian Fainelli: "Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change"
Next in thread: Zach Brown: "Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]