Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

[David Miller]

From: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
Date: Thu, 6 Oct 2016 13:00:55 +0300

> v6:
>  - use sdiag_raw_protocol() helper which will access @pad
>    structure used for raw sockets protocol specification:
>    we can't simply rename this member without breaking uapi.

Macros that look like function calls and are also lvalues tend to be
troublesome.

I know what you're trying to achieve, you want a named way to access
this so that the intent and semantics are clear.

But I'd rather you do something that provides a way by which normal
struct member accesses do the job, and your earlier patches achieved
this.