Re: [PATCH v8 3/6] x86/intel-ivi: Add Intel In-Vehicle Infotainment (IVI) systems used in cars support

[Andy Shevchenko]

On Wed, 2016-10-12 at 14:51 +0800, Tan Jui Nee wrote:
> Add support for non ACPI system, such as system that uses Advanced
> Boot
> Loader (ABL) whereby a platform device has to be created in order to
> bind
> with PINCTRL/GPIO.
> 
> At the moment, Intel Apollo Lake SoC requires P2SB driver to hide and
> unhide P2SB to lookup P2SB BAR and pass the PCI BAR address to GPIO.

I dunno if this patch would go as a last in the series.

> 
> +config X86_INTEL_IVI
> +	bool "Intel In-Vehicle Infotainment (IVI) systems used in
> cars"
> +	---help---
> +	ÂÂSelect this option to enable MMIO BAR access over the P2SB
> for
> +	ÂÂnon-ACPI Intel Apollo Lake SoC platforms.

This sounds not what the option is used for.
What I see from the code as simple as "Enable support of Intel IVI
systems. This enables necessary drivers and libraries which are used in
IVI systems."


>  This driver uses the P2SB
> +	ÂÂhide/unhide mechanism cooperatively to pass the PCI BAR
> address to
> +	ÂÂthe platform driver, currently GPIO.


-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy