Re: [PATCH] mfd: intel-lpss: Do not put device in reset state on suspend

[Andy Shevchenko]

On Wed, 2016-10-12 at 10:12 -0700, Azhar Shaikh wrote:
> Commit 41a3da2b8e163 ("mfd: intel-lpss: Save register context on
> suspend") saved the register context while going to suspend and
> also put the device in reset state.
> 
> Due to the resetting of device, system cannot enter S3/S0ix
> states when no_console_suspend flag is enabled. The system
> and serial console both hang. The resetting of device is not
> needed while going to suspend. Hence remove this code.
> 
> Fixes: 41a3da2b8e163 ("mfd: intel-lpss: Save register context on
> suspend")
> Signed-off-by: Azhar Shaikh <azhar.shaikh@xxxxxxxxx>

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> ---
> Âdrivers/mfd/intel-lpss.c | 3 ---
> Â1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
> index 41b1138..70c646b 100644
> --- a/drivers/mfd/intel-lpss.c
> +++ b/drivers/mfd/intel-lpss.c
> @@ -502,9 +502,6 @@ int intel_lpss_suspend(struct device *dev)
> Â	for (i = 0; i < LPSS_PRIV_REG_COUNT; i++)
> Â		lpss->priv_ctx[i] = readl(lpss->priv + i * 4);
> Â
> -	/* Put the device into reset state */
> -	writel(0, lpss->priv + LPSS_PRIV_RESETS);
> -
> Â	return 0;
> Â}
> ÂEXPORT_SYMBOL_GPL(intel_lpss_suspend);

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy