Re: [PATCH 1/3] mfd: cros_ec: Add EC console read structures definitions

[Nicolas Boichat]

On Wed, Aug 31, 2016 at 4:45 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> On Tue, 23 Aug 2016, Nicolas Boichat wrote:
>
>> ec_params_console_read_v1 is used to capture EC logs from kernel,
>> and ec_params_get_cmd_versions_v1 is used to probe whether EC
>> supports that command.
>>
>> Signed-off-by: Nicolas Boichat <drinkcat@xxxxxxxxxxxx>
>> ---
>>  include/linux/mfd/cros_ec_commands.h | 21 ++++++++++++++++++++-
>
> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
>
> I guess this will be taken through Olof's tree?

What's the status on this patch series? I don't see it being picked up
in any tree...

Thanks,

>>  1 file changed, 20 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h
>> index 7e7a8d4..74c84e82 100644
>> --- a/include/linux/mfd/cros_ec_commands.h
>> +++ b/include/linux/mfd/cros_ec_commands.h
>> @@ -625,6 +625,10 @@ struct ec_params_get_cmd_versions {
>>       uint8_t cmd;      /* Command to check */
>>  } __packed;
>>
>> +struct ec_params_get_cmd_versions_v1 {
>> +     uint16_t cmd;     /* Command to check */
>> +} __packed;
>> +
>>  struct ec_response_get_cmd_versions {
>>       /*
>>        * Mask of supported versions; use EC_VER_MASK() to compare with a
>> @@ -2003,13 +2007,28 @@ struct ec_params_charge_control {
>>  #define EC_CMD_CONSOLE_SNAPSHOT 0x97
>>
>>  /*
>> - * Read next chunk of data from saved snapshot.
>> + * Read data from the saved snapshot. If the subcmd parameter is
>> + * CONSOLE_READ_NEXT, this will return data starting from the beginning of
>> + * the latest snapshot. If it is CONSOLE_READ_RECENT, it will start from the
>> + * end of the previous snapshot.
>> + *
>> + * The params are only looked at in version >= 1 of this command. Prior
>> + * versions will just default to CONSOLE_READ_NEXT behavior.
>>   *
>>   * Response is null-terminated string.  Empty string, if there is no more
>>   * remaining output.
>>   */
>>  #define EC_CMD_CONSOLE_READ 0x98
>>
>> +enum ec_console_read_subcmd {
>> +     CONSOLE_READ_NEXT = 0,
>> +     CONSOLE_READ_RECENT
>> +};
>> +
>> +struct ec_params_console_read_v1 {
>> +     uint8_t subcmd; /* enum ec_console_read_subcmd */
>> +} __packed;
>> +
>>  /*****************************************************************************/
>>
>>  /*
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org â Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog