Re: [PATCH] staging: greybus: timesync.c: Fixed WARNING for brace issue
From: Viresh Kumar
Date: Thu Oct 13 2016 - 00:43:30 EST
On Thu, Oct 13, 2016 at 1:20 AM, Chase Metzger <chasemetzger15@xxxxxxxxx> wrote:
> Removed a checkpatch warning for braces on single argument if and else
> statement.
>
> Signed-off-by: Chase Metzger <chasemetzger15@xxxxxxxxx>
> ---
> drivers/staging/greybus/timesync.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/timesync.c b/drivers/staging/greybus/timesync.c
> index 2e68af7..e586627 100644
> --- a/drivers/staging/greybus/timesync.c
> +++ b/drivers/staging/greybus/timesync.c
> @@ -807,11 +807,11 @@ static int gb_timesync_schedule(struct gb_timesync_svc *timesync_svc, int state)
> return -EINVAL;
>
> mutex_lock(×ync_svc->mutex);
> - if (timesync_svc->state != GB_TIMESYNC_STATE_INVALID) {
> + if (timesync_svc->state != GB_TIMESYNC_STATE_INVALID)
> gb_timesync_set_state_atomic(timesync_svc, state);
> - } else {
> + else
> ret = -ENODEV;
> - }
> +
> mutex_unlock(×ync_svc->mutex);
> return ret;
> }
Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>