Re: [PATCH v2] usb: dwc3: gadget: Wait for end transfer complete before free irq

From: Felipe Balbi
Date: Thu Oct 13 2016 - 03:23:00 EST


Baolin Wang <> writes:
> @@ -1742,6 +1791,17 @@ static int dwc3_gadget_stop(struct usb_gadget *g)
> dwc->gadget_driver = NULL;
> spin_unlock_irqrestore(&dwc->lock, flags);
> + /*
> + * Since the xHCI will share the same interrupt with gadget, thus when
> + * free the gadget irq, it will not shutdown this gadget irq line. Then
> + * the gadget driver can not handle the end transfer command complete
> + * event after free the gadget irq, which will hang the system to crash.
> + *
> + * So we should wait for the end transfer command complete event before
> + * free it to avoid this situation.
> + */
> + dwc3_wait_command_complete(dwc);

this doesn't make sense. We have already masked all interrupts before
getting here. We have also, already, disabled all endpoints.

I'm thinking this is a bug in configfs interface of Gadget API, not
dwc3. The only reason for this to happen would be if we get to
->udc_stop() with endpoints still enabled.

Can you check if that's the case? i.e. can you check if any endpoints
are still enabled when we get here?


Attachment: signature.asc
Description: PGP signature