Re: [Intel-gfx] [patch] drm/i915: fix a read size argument

From: Chris Wilson
Date: Thu Oct 13 2016 - 05:02:55 EST

On Thu, Oct 13, 2016 at 11:55:08AM +0300, Dan Carpenter wrote:
> We want to read 3 bytes here, but because the parenthesis are in the
> wrong place we instead read:
> sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd)
> which is one byte.
> Fixes: fe5a66f91c88 ("drm/i915: Read PSR caps/intermediate freqs/etc. only once on eDP")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Oops, does smatch catch this? I don't recall seeing the complaint in
recent runs?

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Chris Wilson, Intel Open Source Technology Centre