Re: [PATCH] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc()

From: David Miller
Date: Thu Oct 13 2016 - 09:45:46 EST

From: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
Date: Fri, 7 Oct 2016 22:53:43 -0400

> vmxnet3_set_mc() still assumes zero is invalid pa:
> it assumes dma_mapping_error(...,0) returns true if vmxnet3_copy_mc() fails;
> it calls dma_unmap_single() iff new_table_pa is not zero.
> The patch adds an explicit variable to track status of new_table_pa.
> Found by Linux Driver Verification project (
> Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>

Please use "bool" and "true"/"false" for boolean variables.