Re: [PATCH] qed: fix old-style function definition

From: David Miller
Date: Thu Oct 13 2016 - 09:55:49 EST

From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Mon, 10 Oct 2016 13:59:16 +0200

> The definition of qed_get_rdma_ops() is not a prototype unless
> we add 'void' here, as indicated by this W=1 warning:
> drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ʽqed_get_rdma_opsʼ:
> drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style function definition [-Werror=old-style-definition]
> Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Again, Qlogic folks, please properly review patches posted against your