Re: [PATCH] qed: fix old-style function definition

[David Miller]

From: "Mintz, Yuval" <Yuval.Mintz@xxxxxxxxxx>
Date: Thu, 13 Oct 2016 14:15:51 +0000

>> > The definition of qed_get_rdma_ops() is not a prototype unless we add
>> > 'void' here, as indicated by this W=1 warning:
>> >
>> > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ʽqed_get_rdma_opsʼ:
>> > drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style
>> > function definition [-Werror=old-style-definition]
>> >
>> > Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
>> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>> 
>> Again, Qlogic folks, please properly review patches posted against your driver.
>> 
>> Thanks.
> 
> Sorry, managed to miss this one.
> Acked-by: Yuval Mintz <Yuval.Mintz@xxxxxxxxxxxxxxxxxx>

Applied.