Re: [PATCH 10/10] drm/i915/gen9: Don't wrap strings in verify_wm_state()

[Paulo Zanoni]

Em Sex, 2016-10-07 Ãs 20:11 -0400, Lyude escreveu:

Bikesheding: it would be nice to write a commit message explaining why,
even if the message just tells the user to read
Documentation/CodingStyle.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>

> Signed-off-by: Lyude <cpaul@xxxxxxxxxx>
> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> Cc: Ville SyrjÃlà <ville.syrjala@xxxxxxxxxxxxxxx>
> Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
> ---
> Âdrivers/gpu/drm/i915/intel_display.c | 6 ++----
> Â1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index 2c682bc..6191baf 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13498,8 +13498,7 @@ static void verify_wm_state(struct drm_crtc
> *crtc,
> Â		sw_ddb_entry = &sw_ddb->plane[pipe][plane];
> Â
> Â		if (!skl_ddb_entry_equal(hw_ddb_entry,
> sw_ddb_entry)) {
> -			DRM_ERROR("mismatch in DDB state pipe %c
> plane %d "
> -				ÂÂ"(expected (%u,%u), found
> (%u,%u))\n",
> +			DRM_ERROR("mismatch in DDB state pipe %c
> plane %d (expected (%u,%u), found (%u,%u))\n",
> Â				ÂÂpipe_name(pipe), plane + 1,
> Â				ÂÂsw_ddb_entry->start, sw_ddb_entry-
> >end,
> Â				ÂÂhw_ddb_entry->start, hw_ddb_entry-
> >end);
> @@ -13549,8 +13548,7 @@ static void verify_wm_state(struct drm_crtc
> *crtc,
> Â		sw_ddb_entry = &sw_ddb->plane[pipe][PLANE_CURSOR];
> Â
> Â		if (!skl_ddb_entry_equal(hw_ddb_entry,
> sw_ddb_entry)) {
> -			DRM_ERROR("mismatch in DDB state pipe %c
> cursor "
> -				ÂÂ"(expected (%u,%u), found
> (%u,%u))\n",
> +			DRM_ERROR("mismatch in DDB state pipe %c
> cursor (expected (%u,%u), found (%u,%u))\n",
> Â				ÂÂpipe_name(pipe),
> Â				ÂÂsw_ddb_entry->start, sw_ddb_entry-
> >end,
> Â				ÂÂhw_ddb_entry->start, hw_ddb_entry-
> >end);