Re: [PATCH v5 4/4] ata: ATA Command Priority Disabled By Default

From: Tejun Heo
Date: Thu Oct 13 2016 - 19:38:27 EST

Hello, Adam.

Sorry about late reply. Was on vacation.

On Thu, Oct 13, 2016 at 04:00:31PM -0700, Adam Manzanares wrote:
> Add a sysfs entry to turn on priority information being passed
> to a ATA device. By default this feature is turned off.
> This patch depends on ata: Enabling ATA Command Priorities

Looks generally good but can we please use a device attribute name
which is more specific - ie. enable_ncq_prio?