Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json files

From: Jiri Olsa
Date: Fri Oct 14 2016 - 05:07:58 EST


On Thu, Oct 13, 2016 at 02:15:25PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> Handle the Unit field, which is needed to find the right PMU for
> an event. We call it "pmu". Handle the ExtSel field.
> Handle the Filter field. Then output the fields into the pmu-events
> data structures which are compiled into perf.
>
> Filter out zero fields, except for the event itself.

got compile error with this patch:

CC util/pmu.o
In file included from /usr/include/string.h:630:0,
from util/util.h:55,
from util/pmu.c:11:
util/pmu.c: In function âpmu_add_cpu_aliasesâ:
util/pmu.c:552:35: error: ânameâ undeclared (first use in this function)
if (pe->pmu && strncmp(pe->pmu, name, strlen(pe->pmu)))
^
util/pmu.c:552:35: note: each undeclared identifier is reported only once for each function it appears in
mv: cannot stat 'util/.pmu.o.tmp': No such file or directory
/home/jolsa/kernel/linux-perf/tools/build/Makefile.build:91: recipe for target 'util/pmu.o' failed


jirka