Re: [media] RedRat3: Move two assignments in redrat3_transmit_ir()?

From: SF Markus Elfring
Date: Fri Oct 14 2016 - 08:02:18 EST

Next message: Rafael J. Wysocki: "Re: [PATCH v8 0/8] power: add power sequence library"
Previous message: Carlos Palminha: "[PATCH v3] i2c: i2c-piix4: several coding style fixes"
In reply to: Dan Carpenter: "Re: [PATCH 02/18] [media] RedRat3: Move two assignments in redrat3_transmit_ir()"
Next in thread: SF Markus Elfring: "[PATCH 04/18] [media] RedRat3: One function call less in redrat3_transmit_ir() after error detection"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> The original code was correct.

Your view can be appropriate for this function implementation to some degree.

I got the impression that it contains the specification of assignments
which will happen a bit too early here.
Is this a weakness for which software developers can care about?

Regards,
Markus

Next message: Rafael J. Wysocki: "Re: [PATCH v8 0/8] power: add power sequence library"
Previous message: Carlos Palminha: "[PATCH v3] i2c: i2c-piix4: several coding style fixes"
In reply to: Dan Carpenter: "Re: [PATCH 02/18] [media] RedRat3: Move two assignments in redrat3_transmit_ir()"
Next in thread: SF Markus Elfring: "[PATCH 04/18] [media] RedRat3: One function call less in redrat3_transmit_ir() after error detection"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]