Re: [GIT PULL] PCI changes for v4.9
From: Bjorn Helgaas
Date: Fri Oct 14 2016 - 09:27:49 EST
On Thu, Oct 13, 2016 at 05:21:40PM -0700, Linus Torvalds wrote:
> On Thu, Oct 13, 2016 at 4:48 PM, Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> > Ugh:
> > Your "summary" is actually less legible than the shortlog, and looks
> > entirely auto-generated.
> > That's against the whole point of having a summary for a pull request.
> > Please tell me what changed, don't auto-generate pointless unreadable crud. Ok?
> I wrote some kind of summary based on actually (hopefully) intelligent
> culling of relevant information instead of just bunching up together
> automated data.
> It may not be complete, but it's the kind of "what does this merge
> actually _merge_" information that is useful. Please do something like
> this in the future rather than the automated illegible mush:
> - use local struct device pointers in many host bridge drivers for
> - remove unused platform data
> - use generic DesignWare accessors
> - misc cleanups: remove redundant structure entries and re-order
> structure members to put comon generic fields first etc"
That's accurate, thank you, and sorry for not providing it myself.
I guess I've always been a little confused on what to put in the email
vs. what should be in the tag message itself. I'm glad you pointed
this out because it's just dawning on me that the tag message does not
become part of your tree when you pull the tag, while the summary from
the email pull request normally does. I've been focusing on the tag
message, not the email summary, which was completely backwards.